Fix PHP notice in Utils\Error::get() #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MauricioFauth
commented
Jan 20, 2024
MauricioFauth
commented
PHP Notice: Trying to get property 'token' of non-object in src/Utils/Error.php on line 54 PHP Notice: Trying to get property 'position' of non-object in src/Utils/Error.php on line 55 Signed-off-by: Maurício Meneghini Fauth <[email protected]>
MauricioFauth
force-pushed
the
fix-notice-error
branch
from
abaa086 to
9851579
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #541 +/- ##
=========================================
Coverage 96.78% 96.78%
- Complexity 2253 2255 +2
=========================================
Files 69 69
Lines 5171 5171
=========================================
Hits 5005 5005
Misses 166 166 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.