Fix keywords not being recognized as table alias #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Signed-off-by: Maurício Meneghini Fauth <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 5.9.x #542 +/- ##
=========================================
Coverage 96.78% 96.79%
- Complexity 2255 2257 +2
=========================================
Files 69 69
Lines 5171 5172 +1
=========================================
+ Hits 5005 5006 +1
Misses 166 166 ☔ View full report in Codecov by Sentry. |
MauricioFauth
commented
Jan 20, 2024
Comment on lines
+2
to
3
| SELECT * FROM `tablename`; | ||
| commit; |
There was a problem hiding this comment.
Here, commit was being treated as an alias of tablename, and that wasn't the purpose of this test.
williamdes
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iokeyword as table alias fails to parse #496