Skip to content

Drop Utils\Routine class #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Drop Utils\Routine class #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 0 additions & 45 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,51 +875,6 @@ parameters:
count: 1
path: src/Utils/Query.php

-
message: "#^Cannot access offset 'value' on mixed\\.$#"
count: 3
path: src/Utils/Routine.php

-
message: "#^Cannot access property \\$name on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
count: 2
path: src/Utils/Routine.php

-
message: "#^Cannot access property \\$options on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
count: 2
path: src/Utils/Routine.php

-
message: "#^Cannot access property \\$options on PhpMyAdmin\\\\SqlParser\\\\Components\\\\OptionsArray\\|null\\.$#"
count: 3
path: src/Utils/Routine.php

-
message: "#^Cannot access property \\$parameters on PhpMyAdmin\\\\SqlParser\\\\Components\\\\DataType\\|null\\.$#"
count: 3
path: src/Utils/Routine.php

-
message: "#^Cannot assign new offset to array\\<int\\<0, max\\>, mixed\\>\\|string\\.$#"
count: 1
path: src/Utils/Routine.php

-
message: "#^Method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Routine\\:\\:getParameter\\(\\) should return array\\<string\\> but returns array\\<int, string\\|null\\>\\.$#"
count: 1
path: src/Utils/Routine.php

-
message: "#^Method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Routine\\:\\:getReturnType\\(\\) should return array\\<string\\> but returns array\\<int, string\\|null\\>\\.$#"
count: 1
path: src/Utils/Routine.php

-
message: "#^Parameter \\#2 \\$array of function implode expects array\\|null, array\\<int\\<0, max\\>, mixed\\>\\|string given\\.$#"
count: 1
path: src/Utils/Routine.php

-
message: "#^Cannot access property \\$database on PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\|null\\.$#"
count: 1
Expand Down
69 changes: 0 additions & 69 deletions psalm-baseline.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,68 +1161,6 @@
<code><![CDATA[empty($statement->order)]]></code>
</RiskyTruthyFalsyComparison>
</file>
<file src="src/Utils/Routine.php">
<InvalidReturnStatement>
<code><![CDATA[[
$type->name,
implode(',', $type->parameters),
implode(' ', $options),
]]]></code>
<code><![CDATA[[
empty($param->inOut) ? '' : $param->inOut,
$param->name,
$param->type->name,
implode(',', $param->type->parameters),
implode(' ', $options),
]]]></code>
</InvalidReturnStatement>
<InvalidReturnType>
<code><![CDATA[string[]]]></code>
<code><![CDATA[string[]]]></code>
</InvalidReturnType>
<MixedArgumentTypeCoercion>
<code><![CDATA[$options]]></code>
<code><![CDATA[$options]]></code>
<code><![CDATA[$retval['opts'][$idx]]]></code>
</MixedArgumentTypeCoercion>
<MixedArrayAccess>
<code><![CDATA[$opt['value']]]></code>
<code><![CDATA[$opt['value']]]></code>
<code><![CDATA[$opt['value']]]></code>
</MixedArrayAccess>
<MixedAssignment>
<code><![CDATA[$opt]]></code>
<code><![CDATA[$opt]]></code>
<code><![CDATA[$opt]]></code>
<code><![CDATA[$options[]]]></code>
<code><![CDATA[$options[]]]></code>
<code><![CDATA[$retval['opts'][$idx][]]]></code>
</MixedAssignment>
<PossiblyNullArgument>
<code><![CDATA[$param->type->parameters]]></code>
<code><![CDATA[$param->type->parameters]]></code>
</PossiblyNullArgument>
<PossiblyNullIterator>
<code><![CDATA[$param->type->options->options]]></code>
<code><![CDATA[$param->type->options->options]]></code>
<code><![CDATA[$type->options->options]]></code>
</PossiblyNullIterator>
<PossiblyNullPropertyFetch>
<code><![CDATA[$param->type->name]]></code>
<code><![CDATA[$param->type->name]]></code>
<code><![CDATA[$param->type->options]]></code>
<code><![CDATA[$param->type->options]]></code>
<code><![CDATA[$param->type->options->options]]></code>
<code><![CDATA[$param->type->options->options]]></code>
<code><![CDATA[$param->type->parameters]]></code>
<code><![CDATA[$param->type->parameters]]></code>
<code><![CDATA[$type->options->options]]></code>
</PossiblyNullPropertyFetch>
<RiskyTruthyFalsyComparison>
<code><![CDATA[empty($param->inOut)]]></code>
<code><![CDATA[empty($statement->parameters)]]></code>
</RiskyTruthyFalsyComparison>
</file>
<file src="src/Utils/Table.php">
<LessSpecificReturnStatement>
<code><![CDATA[$ret]]></code>
Expand Down Expand Up @@ -1500,13 +1438,6 @@
<code><![CDATA[getTablesProvider]]></code>
</PossiblyUnusedMethod>
</file>
<file src="tests/Utils/RoutineTest.php">
<PossiblyUnusedMethod>
<code><![CDATA[getParameterProvider]]></code>
<code><![CDATA[getParametersProvider]]></code>
<code><![CDATA[getReturnTypeProvider]]></code>
</PossiblyUnusedMethod>
</file>
<file src="tests/Utils/TableTest.php">
<PossiblyUnusedMethod>
<code><![CDATA[getFieldsProvider]]></code>
Expand Down
137 changes: 0 additions & 137 deletions src/Utils/Routine.php
View file
Open in desktop

This file was deleted.

Loading
Loading