Skip to content

Fix #610 - Add the missing options to handle in the context of ALTER TABLE statement: "UNIQUE" and "UNIQUE KEY" #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix #610 - Add the missing options to handle in the context of ALTER TABLE statement: "UNIQUE" and "UNIQUE KEY" #611

wants to merge 2 commits into from

Conversation

niconoe-
Copy link
Contributor

Fix #610 by adding the missing options to handle in the context of ALTER TABLE statement: "UNIQUE" and "UNIQUE KEY".

@williamdes williamdes changed the title Fix/610 Fix #610 - Add the missing options to handle in the context of ALTER TABLE statement: "UNIQUE" and "UNIQUE KEY" Jan 30, 2025
williamdes
williamdes reviewed Jan 30, 2025
View reviewed changes
@niconoe-
Copy link
Contributor Author

niconoe- commented Jan 30, 2025 •
edited
Loading

I fixed this in the 5.11.x. Would it be possible to have it on 5.10.x too? If yes, should I provide another PR from the 5.10.x branch?

PR forced-push since 5.10.x now. Thanks.

@williamdes
Copy link
Member

I fixed this in the 5.11.x. Would it be possible to have it on 5.10.x too? If yes, should I provide another PR from the 5.10.x branch?

You can hard reset on 5.10, cherry pick your work and force push it. Then edit the PR for 5.10.
Then it can be merged to all versions above

@niconoe- niconoe- changed the base branch from 5.11.x to 5.10.x January 30, 2025 13:41
@niconoe- niconoe- mentioned this pull request Feb 3, 2025
Closed
@MauricioFauth MauricioFauth self-assigned this Feb 22, 2025
@MauricioFauth MauricioFauth added this to the 5.11.0 milestone Feb 22, 2025
MauricioFauth added a commit that referenced this pull request Feb 22, 2025
@MauricioFauth
Merge PR #611 Add "UNIQUE" and "UNIQUE KEY" to ALTER TABLE statement
f40c620 
Fixes #610

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@MauricioFauth
Copy link
Member

Merged by f40c620.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamdes williamdes williamdes approved these changes

@MauricioFauth MauricioFauth MauricioFauth approved these changes

Assignees

@MauricioFauth MauricioFauth

Labels

None yet

Projects

None yet

Milestone

5.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@niconoe- @williamdes @MauricioFauth