Add phpdoc for transformation methods into other Collection stubs #622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xificurk
force-pushed
the
fix-collection-transaformations
branch
from
00d6bd9 to
267a5ef
Compare
|
Please base it on top of 1.5.x (where the bug actually is and already released). |
|
Sorry, base changed... I don't understand the failure on 7.4 and 8.0, it seems related to doctrine/collections 1.8. |
|
doctrine/collections 1.8 is the first version that got a extracted |
|
Ah, I see, there is no Solved. |
xificurk
force-pushed
the
fix-collection-transaformations
branch
from
47b044a to
65ab71e
Compare
xificurk
force-pushed
the
fix-collection-transaformations
branch
from
65ab71e to
0db7b22
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #621
This is basically the same road as Doctrine itself took - repeat the modified phpdoc in the child interfaces/classes.