Fixing tests #631
Merged
Fixing tests #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/tests
branch
from
8a469a0 to
65e6caa
Compare
ondrejmirtes
requested changes
Nov 20, 2024
VincentLanglet
force-pushed
the
fix/tests
branch
from
3559792 to
f33a8d1
Compare
VincentLanglet
force-pushed
the
fix/tests
branch
from
30ccac9 to
befdd01
Compare
|
Thank you. |
|
@ondrejmirtes This is doing more than fixing tests, it also improve the type inferred with lower/upper case. So it might worth a new release some times... (and maybe @janedbal you want to take a look) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.