Fix PHPStan crashing with single value enum #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
changed the title
VincentLanglet
force-pushed
the
singleEnum
branch
from
61f0957 to
7274ada
Compare
|
Failures seems unrelated |
ondrejmirtes
requested changes
Oct 6, 2025
| $writableToPropertyType = new UnionType($enumTypes); | ||
| $writableToDatabaseType = new UnionType($enumTypes); | ||
| $writableToPropertyType = TypeCombinator::union(...$enumTypes); | ||
| $writableToDatabaseType = TypeCombinator::union(...$enumTypes); |
There was a problem hiding this comment.
Think of the machine and do the exact same union call only once :) Thank you.
There was a problem hiding this comment.
Sure, if you can wait 5 min for the release, I'll do it now.
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ondrejmirtes I discovered a bug introduced by #678
When an enum has only one value, I tried to do a Union of a single type and it crash with a ShouldNotHappenException.
I added a reproducer and a fix.