feat: Discourage assert(Not)Empty if "empty" usage is disallowed - #325
Open
mitelg wants to merge 1 commit into
Open
feat: Discourage assert(Not)Empty if "empty" usage is disallowed#325mitelg wants to merge 1 commit into
mitelg wants to merge 1 commit into
Conversation
mitelg
force-pushed
the
feat/dissallow-assert-empty
branch
from
August 21, 2026 09:40
7aaebe3 to
410764b
Compare
mitelg
force-pushed
the
feat/dissallow-assert-empty
branch
from
August 21, 2026 09:45
410764b to
927cf58
Compare
mitelg
commented
Aug 21, 2026
| PHPStan\Rules\PHPUnit\AssertEqualsIsDiscouragedRule: | ||
| phpstan.rules.rule: [%strictRulesInstalled%, %featureToggles.bleedingEdge%] | ||
| PHPStan\Rules\PHPUnit\AssertEmptyIsDiscouragedRule: | ||
| phpstan.rules.rule: %strictRulesInstalled% |
Contributor
Author
There was a problem hiding this comment.
I would like to bind it to the %strictRules.disallowedEmpty% toggle as well, but seems not be possible 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #270
Hey,
first attempt to fix the linked issue. I used Codex for that and I hope it did the job correct 😁 Tests are looking fine for me.
Happy to get some feedback 🤝
Best regards 👋