Test generics in TypesAssignedToPropertiesRule for hooked properties

Author: ondrejmirtes

tests/PHPStan/Rules/Properties/TypesAssignedToPropertiesRuleTest.php

@@ -741,6 +741,23 @@ public function testPropertyHooks(): void
 				'Property AssignHookedProperties\Foo::$i (array<string>|int) does not accept array<int, int>.',
 				27,
 			],
+			[
+				'Property AssignHookedProperties\FooGenerics<int>::$a (int) does not accept string.',
+				52,
+			],
+			[
+				'Property AssignHookedProperties\FooGenerics<T>::$a (T) does not accept int.',
+				61,
+				'Type int is not always the same as T. It breaks the contract for some argument types, typically subtypes.',
+			],
+			[
+				'Property AssignHookedProperties\FooGenericsParam<T>::$a (array<T>) does not accept array<T>|int.',
+				76,
+			],
+			[
+				'Property AssignHookedProperties\FooGenericsParam<int>::$a (array<int>|int) does not accept array<int, string>.',
+				91,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Properties/data/assign-hooked-properties.php

@@ -28,3 +28,76 @@ public function doFoo(): void
 	}
 
 }
+
+/**
+ * @template T
+ */
+class FooGenerics
+{
+
+	/** @var T */
+	public $a {
+		set {
+			$this->a = $value;
+		}
+	}
+
+	/**
+	 * @param FooGenerics<int> $f
+	 * @return void
+	 */
+	public static function doFoo(self $f): void
+	{
+		$f->a = 1;
+		$f->a = 'foo';
+	}
+
+	/**
+	 * @param T $t
+	 */
+	public function doBar($t): void
+	{
+		$this->a = $t;
+		$this->a = 1;
+	}
+
+}
+
+/**
+ * @template T
+ */
+class FooGenericsParam
+{
+
+	/** @var array<T> */
+	public array $a {
+		/** @param array<T>|int $value */
+		set (array|int $value) {
+			$this->a = $value; // not ok
+
+			if (is_array($value)) {
+				$this->a = $value; // ok
+			}
+		}
+	}
+
+	/**
+	 * @param FooGenericsParam<int> $f
+	 * @return void
+	 */
+	public static function doFoo(self $f): void
+	{
+		$f->a = [1]; // ok
+		$f->a = ['foo']; // not ok
+	}
+
+	/**
+	 * @param T $t
+	 */
+	public function doBar($t): void
+	{
+		$this->a = [$t]; // ok
+		$this->a = 1; // ok
+	}
+
+}