Test ReadingWriteOnlyPropertiesRule for hooked properties

Author: ondrejmirtes

src/Reflection/Php/PhpPropertyReflection.php

@@ -174,7 +174,15 @@ public function getNativeType(): Type
 
 	public function isReadable(): bool
 	{
-		return true;
+		if ($this->isStatic()) {
+			return true;
+		}
+
+		if (!$this->isVirtual()->yes()) {
+			return true;
+		}
+
+		return $this->hasHook('get');
 	}
 
 	public function isWritable(): bool

tests/PHPStan/Rules/Properties/ReadingWriteOnlyPropertiesRuleTest.php

@@ -5,6 +5,7 @@
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleLevelHelper;
 use PHPStan\Testing\RuleTestCase;
+use const PHP_VERSION_ID;
 
 /**
  * @extends RuleTestCase<ReadingWriteOnlyPropertiesRule>
@@ -88,4 +89,23 @@ public function testConflictingAnnotationProperty(): void
 		$this->analyse([__DIR__ . '/data/conflicting-annotation-property.php'], []);
 	}
 
+	public function testPropertyHooks(): void
+	{
+		if (PHP_VERSION_ID < 80400) {
+			$this->markTestSkipped('Test requires PHP 8.4.');
+		}
+
+		$this->checkThisOnly = false;
+		$this->analyse([__DIR__ . '/data/reading-write-only-hooked-properties.php'], [
+			[
+				'Property ReadingWriteOnlyHookedProperties\Foo::$i is not readable.',
+				16,
+			],
+			[
+				'Property ReadingWriteOnlyHookedProperties\Bar::$i is not readable.',
+				34,
+			],
+		]);
+	}
+
 }

tests/PHPStan/Rules/Properties/data/reading-write-only-hooked-properties.php

@@ -0,0 +1,51 @@
+<?php // lint >= 8.4
+
+namespace ReadingWriteOnlyHookedProperties;
+
+interface Foo
+{
+
+	public int $i {
+		// virtual, not readable
+		set;
+	}
+
+}
+
+function (Foo $f): void {
+	echo $f->i;
+};
+
+class Bar
+{
+
+	public int $other;
+
+	public int $i {
+		// virtual, not readable
+		set {
+			$this->other = 1;
+		}
+	}
+
+}
+
+function (Bar $b): void {
+	echo $b->i;
+};
+
+class Baz
+{
+
+	public int $i {
+		// backed, readable
+		set {
+			$this->i = 1;
+		}
+	}
+
+}
+
+function (Baz $b): void {
+	$b->i = 1;
+};