FileTypeMapper: Prevent unnecessary file IO

staabm · ondrejmirtes · commit abcab840bca3 · 2026-01-14T07:45:39.000+01:00
diff --git a/src/Type/FileTypeMapper.php b/src/Type/FileTypeMapper.php
@@ -367,11 +367,11 @@ private function loadCachedPhpDocNodeMap(string $cacheKey, string $variableCache
 			[$nameScopeMap, $filesWithHashes] = $cached;
 			$useCache = true;
 			foreach ($filesWithHashes as $file => $hash) {
-				if (!is_file($file)) {
+				$newHash = @hash_file('sha256', $file);
+				if ($newHash === false) {
 					$useCache = false;
 					break;
 				}
-				$newHash = hash_file('sha256', $file);
 				if ($newHash === $hash) {
 					continue;
 				}

Original file line number	Diff line number	Diff line change
`@@ -367,11 +367,11 @@ private function loadCachedPhpDocNodeMap(string $cacheKey, string $variableCache`
`367`	`367`	`[$nameScopeMap, $filesWithHashes] = $cached;`
`368`	`368`	`$useCache = true;`
`369`	`369`	`foreach ($filesWithHashes as $file => $hash) {`
`370`		`- if (!is_file($file)) {`
	`370`	`+ $newHash = @hash_file('sha256', $file);`
	`371`	`+ if ($newHash === false) {`
`371`	`372`	`$useCache = false;`
`372`	`373`	`break;`
`373`	`374`	`}`
`374`		`- $newHash = hash_file('sha256', $file);`
`375`	`375`	`if ($newHash === $hash) {`
`376`	`376`	`continue;`
`377`	`377`	`}`