[BCB] Remove PropertyTag::getType()

Author: ondrejmirtes

UPGRADING.md

@@ -242,3 +242,4 @@ Instead of `PHPStanTestCase::createBroker()`, call `PHPStanTestCase::createRefle
 * Remove `ClassReflection::getFileNameWithPhpDocs()`, use `getFileName()` instead
 * Remove `AnalysisResult::getInternalErrors()`, use `getInternalErrorObjects()` instead
 * Remove `ConstantReflection::getValue()`, use `getValueExpr()` instead. To get `Type` from `Expr`, use `Scope::getType()` or `InitializerExprTypeResolver::getType()`
+* Remove `PropertyTag::getType()`, use `getReadableType()` / `getWritableType()` instead

src/PhpDoc/PhpDocNodeResolver.php

@@ -112,7 +112,6 @@ public function resolvePropertyTags(PhpDocNode $phpDocNode, NameScope $nameScope
 				$resolved[$propertyName] = new PropertyTag(
 					$propertyType,
 					$propertyType,
-					$propertyType,
 				);
 			}
 		}
@@ -128,7 +127,6 @@ public function resolvePropertyTags(PhpDocNode $phpDocNode, NameScope $nameScope
 				}
 
 				$resolved[$propertyName] = new PropertyTag(
-					$propertyType,
 					$propertyType,
 					$writableType,
 				);
@@ -146,7 +144,6 @@ public function resolvePropertyTags(PhpDocNode $phpDocNode, NameScope $nameScope
 				}
 
 				$resolved[$propertyName] = new PropertyTag(
-					$readableType ?? $propertyType,
 					$readableType,
 					$propertyType,
 				);

src/PhpDoc/Tag/PropertyTag.php

@@ -11,21 +11,12 @@ final class PropertyTag
 {
 
 	public function __construct(
-		private Type $type,
 		private ?Type $readableType,
 		private ?Type $writableType,
 	)
 	{
 	}
 
-	/**
-	 * @deprecated Use getReadableType() / getWritableType()
-	 */
-	public function getType(): Type
-	{
-		return $this->type;
-	}
-
 	public function getReadableType(): ?Type
 	{
 		return $this->readableType;