Fix return type of round/ceil/floor in non strict type environment #3223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 1.12.x. If your code is relevant on 1.11.x and you want it to be released sooner, please rebase your pull request and change its target to 1.11.x. |
BackEndTea
force-pushed
the
round-type-non-declare-strict
branch
from
f1611f7 to
458740e
Compare
BackEndTea
force-pushed
the
round-type-non-declare-strict
branch
from
458740e to
ff77af7
Compare
In non declare strict types the round functions are able to handle numeric strings, null and bools. See also: https://3v4l.org/5io0n And issue phpstan/phpstan#11319
BackEndTea
force-pushed
the
round-type-non-declare-strict
branch
from
ff77af7 to
34bbe41
Compare
|
Thank you! |
|
Thanks for the merge @ondrejmirtes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In non declare strict types the round functions are able to handle numeric strings, null and bools.
See also: https://3v4l.org/5io0n
And issue phpstan/phpstan#11319