RegularExpressionPatternRule: fix false positive in preg_quote() handling #3275
Conversation
|
//cc @Seldaek |
| @@ -44,7 +44,7 @@ public function resolve(Expr $expr): Type | |||
| && $expr->name instanceof Name | |||
| && $expr->name->toLowerString() === 'preg_quote' | |||
| ) { | |||
| return new ConstantStringType(''); | |||
| return new ConstantStringType('.*'); | |||
There was a problem hiding this comment.
instead of dummy-replace preg_quote($x) with '' we use .* as a placeholder, so we don't produce invalid patterns
There was a problem hiding this comment.
Can you please explain the constant string meaning? AFAICT such assumption here can produce misleading assumptions/phpstan errors.
There was a problem hiding this comment.
We replace a preg_quote with some constant value so we can finally resolve a string concatenation to a pattern at analysis time.
The preg_quoted value cannot return something which creates capturing groups or syntax errors, therefore we simplify it to improve coverage
There was a problem hiding this comment.
It'd probably help to have some more comments explaining these edge cases / hacks to future archeologists 😅 but PR looks good thanks
|
This pull request has been marked as ready for review. |
|
Thank you. |
closes phpstan/phpstan#11403