Skip to content

ShouldNotHappenException extends LogicException #3297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ShouldNotHappenException extends LogicException #3297

wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Aug 6, 2024 •
edited
Loading

before this PR PHPStorm false-postively reporting missing handling of ShouldNotHappenExceptions

grafik

LogicException

Exception that represents error in the program logic. This kind of exception should lead directly to a fix in your code.

see https://www.php.net/LogicException

@ondrejmirtes
Copy link
Member

Errr, no. I always turn off these PhpStorm inspections. PHPStan's exception checking is much more flexible.

@staabm staabm deleted the should-logic branch August 6, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staabm @ondrejmirtes