RegexArrayShapeMatcher - fix capturing item-array-shapes for preg_match_all #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 8, 2024
Comment on lines
+397
to
+405
| if (!$this->containsSetOrder($flags) && !$this->containsUnmatchedAsNull($flags, $matchesAll) && $captureGroup->isOptional()) { | ||
| $groupValueType = $this->getValueType( | ||
| TypeCombinator::union($captureGroup->getType(), new ConstantStringType('')), | ||
| $flags, | ||
| $matchesAll, | ||
| ); | ||
| $groupValueType = TypeCombinator::removeNull($groupValueType); | ||
| } else { | ||
| $groupValueType = $this->getValueType($captureGroup->getType(), $flags, $matchesAll); |
There was a problem hiding this comment.
staabm
commented
Aug 8, 2024
| @@ -474,6 +478,8 @@ private function getValueType(Type $baseType, int $flags, bool $matchesAll): Typ | |||
| $offsetType = IntegerRangeType::fromInterval(0, null); | |||
| if ($this->containsUnmatchedAsNull($flags, $matchesAll)) { | |||
| $valueType = TypeCombinator::addNull($valueType); | |||
| } | |||
| if ($this->containsUnmatchedAsNull($flags, $matchesAll) || $matchesAll) { | |||
| // unmatched groups return -1 as offset | |||
| $offsetType = IntegerRangeType::fromInterval(-1, null); | |||
There was a problem hiding this comment.
preg_match_all can yield -1 in capturing offset, even without PREG_UNMATCHED_AS_NULL
There was a problem hiding this comment.
hmm.. the same is true for preg_match - https://3v4l.org/Yra1j
|
This pull request has been marked as ready for review. |
|
phpstan-nette needs expectation adjustments |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.