Skip to content

Update PhpStorm stubs #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update PhpStorm stubs #3334

wants to merge 1 commit into from

Conversation

phpstan-bot
Copy link
Collaborator

Update PhpStorm stubs

@ondrejmirtes ondrejmirtes mentioned this pull request Aug 26, 2024
Closed
@VincentLanglet
Copy link
Contributor

Hi @ondrejmirtes,

The failing test is because https://github.com/JetBrains/phpstorm-stubs/pull/1652/files was merged which add a throw annotation to the modify method. You reported I forgot this here JetBrains/phpstorm-stubs#1646 (comment) on a PR which already introduce some issue on PHPStan side.

It seems kinda related to phpstan/phpstan#11503 (with the sub method).

Stubs are correct for PHP >= 8.3 but in PHP < 8.3:

  • DateTime::sub throws void
  • DateTimeImmutable::sub throws void
  • DateTime::modify throws void
  • DateTimeImmutable::modify throws void

Should it be done with a DynamicMethodThrowTypeExtension for PHP < 8.3 or something else ?

@VincentLanglet VincentLanglet mentioned this pull request Aug 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phpstan-bot @VincentLanglet @ondrejmirtes