Narrow to non-falsy-string from strlen() on integer-range #3337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
realized we also could do better in == and === logged as phpstan/phpstan#11548 as I don't want todo it right now |
staabm
commented
Aug 22, 2024
| @@ -323,7 +323,8 @@ public function specifyTypesInCondition( | |||
| $argType = $scope->getType($expr->right->getArgs()[0]->value); | |||
| if ($argType->isString()->yes()) { | |||
| $accessory = new AccessoryNonEmptyStringType(); | |||
| if ($leftType instanceof ConstantIntegerType && $leftType->getValue() >= 2) { | |||
There was a problem hiding this comment.
the old code missed to handle $offset which turns into off-by-one errors on smaller/greater comparisons
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.