Fix return type of array_reverse() with $preserve_keys = true for lists
#3341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
array-reverse-list
branch
from
a365a7e to
87daf25
Compare
herndlm
commented
Aug 22, 2024
Comment on lines
+49
to
+55
| // Remove list | ||
| $newArrayType = new ArrayType($type->getIterableKeyType(), $type->getIterableValueType()); | ||
| if ($type->isIterableAtLeastOnce()->yes()) { | ||
| $newArrayType = TypeCombinator::intersect($newArrayType, new NonEmptyArrayType()); | ||
| } | ||
|
|
||
| return $newArrayType; |
There was a problem hiding this comment.
An almost identical construct exists already somewhere. And I might add it another time somewhere else. I was wondering if it makes sense to re-use this somehow somewhere..
There was a problem hiding this comment.
the cleaner alternative of course would be a refactor that moves reverse() to Type (arrayReverse()?). The more I think about it, the more I like it 😊
There was a problem hiding this comment.
yeah, moving this to type fixes like at least 3 other edge cases as well....
herndlm
force-pushed
the
array-reverse-list
branch
from
87daf25 to
6f217f1
Compare
|
Superseded by #3344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.