Move result cache output from debug to very verbose mode #3345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any remarks? We switched to |
ondrejmirtes
requested changes
Sep 18, 2024
janedbal
force-pushed
the
result-cache-verbose
branch
from
796d854 to
82f8844
Compare
janedbal
changed the title
ondrejmirtes
requested changes
Oct 6, 2024
| } | ||
| if (!is_file($extensionFile)) { | ||
| if ($output->isDebug()) { | ||
| if ($output->isVerbose()) { |
There was a problem hiding this comment.
Should be isVeryVerbose() in places where you still left isVerbose().
There was a problem hiding this comment.
Missed this one, thx
There was a problem hiding this comment.
Fixed. Double checked, last one in verbose mode is the "Result cache restored", would you keep it?
ondrejmirtes
reviewed
Oct 9, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there are more and more
DiagnoseExtensionswith spammy output being added, we are switching from-vvvto-vvmode. But I think result cache info is still pretty important even when debug mode is not enabled, so I changed it.