Skip to content

PHP 8.4 runtime support #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Aug 26, 2024
Merged

PHP 8.4 runtime support #3350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e28715a
Allow running on PHP 8.4
ondrejmirtes Aug 26, 2024
20e841d
Test on PHP 8.4
ondrejmirtes Aug 26, 2024
a02d4e2
Update react/socket
ondrejmirtes Aug 26, 2024
cebddd4
Exit as function
ondrejmirtes Aug 26, 2024
ac49dd8
Update react/child-process
ondrejmirtes Aug 26, 2024
428779d
Update PHPUnit to 9.6 in CI
ondrejmirtes Aug 26, 2024
c4b0438
Update nette/neon
ondrejmirtes Aug 26, 2024
bc82a72
Patch nette/neon
ondrejmirtes Aug 26, 2024
f24bb63
Update BetterReflection
ondrejmirtes Aug 26, 2024
0e821fe
Update nette/php-generator
ondrejmirtes Aug 26, 2024
f3b1824
Update BetterReflection again
ondrejmirtes Aug 26, 2024
d9477f9
Fix tests
ondrejmirtes Aug 26, 2024
16e125d
Patch hoa
ondrejmirtes Aug 26, 2024
5f2812d
Replace highlight_string() stub with a return type extension
ondrejmirtes Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"

steps:
- name: "Checkout"
Expand All @@ -50,7 +51,7 @@ jobs:
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

- name: "Lint"
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/reflection-golden-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"

steps:
- uses: Wandalen/[email protected]
Expand Down Expand Up @@ -101,7 +102,7 @@ jobs:
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

Expand All @@ -120,7 +121,7 @@ jobs:
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

Expand Down
11 changes: 10 additions & 1 deletion .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
operating-system: [ubuntu-latest, windows-latest]

steps:
Expand All @@ -56,7 +57,7 @@ jobs:
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

Expand All @@ -69,6 +70,10 @@ jobs:
if: matrix.php-version == '7.2'
run: "composer require --dev phpunit/phpunit:^8.5.31 brianium/paratest:^4.0 composer/semver:^1.2 --update-with-dependencies --ignore-platform-reqs"

- name: "Update PHPUnit"
if: matrix.php-version != '7.2' && matrix.php-version != '7.3'
run: "composer update phpunit/phpunit -W"

- name: "PHPStan"
run: "make phpstan"

Expand All @@ -85,6 +90,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"

steps:
- name: "Checkout"
Expand All @@ -101,6 +107,9 @@ jobs:
- name: "Install dependencies"
run: "composer install --no-interaction --no-progress"

- name: "Update PHPUnit"
run: "composer update phpunit/phpunit -W"

- name: "Cache Result cache"
uses: actions/cache@v4
with:
Expand Down
7 changes: 6 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ jobs:
- "8.1"
- "8.2"
- "8.3"
- "8.4"
operating-system: [ ubuntu-latest, windows-latest ]

steps:
Expand All @@ -61,10 +62,14 @@ jobs:
run: "composer install --no-interaction --no-progress"

- name: "Transform source code"
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3'
if: matrix.php-version != '8.1' && matrix.php-version != '8.2' && matrix.php-version != '8.3' && matrix.php-version != '8.4'
shell: bash
run: "vendor/bin/simple-downgrade downgrade -c build/downgrade.php ${{ matrix.php-version }}"

- name: "Update PHPUnit"
if: matrix.php-version != '7.3'
run: "composer update phpunit/phpunit -W"

- name: "Tests"
run: "make tests"

Expand Down
1 change: 1 addition & 0 deletions build/composer-dependency-analyser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
'symfony/process',
'symfony/service-contracts',
'symfony/string',
'nette/php-generator',
];

return $config
Expand Down
22 changes: 18 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,18 @@
"jetbrains/phpstorm-stubs": "dev-master#bdc8acd7c04c0c87197849c7cdd27e44b67b56c7",
"nette/bootstrap": "^3.0",
"nette/di": "^3.1.4",
"nette/neon": "^3.3.1",
"nette/neon": "3.3.3",
"nette/php-generator": "3.6.9",
"nette/schema": "^1.2.2",
"nette/utils": "^3.2.5",
"nikic/php-parser": "^4.17.1",
"ondram/ci-detector": "^3.4.0",
"ondrejmirtes/better-reflection": "6.25.0.15",
"ondrejmirtes/better-reflection": "6.25.0.17",
"phpstan/php-8-stubs": "0.3.97",
"phpstan/phpdoc-parser": "1.29.1",
"psr/http-message": "^1.1",
"react/async": "^3",
"react/child-process": "^0.6.4",
"react/child-process": "^0.7",
"react/dns": "^1.10",
"react/event-loop": "^1.2",
"react/http": "^1.1",
Expand Down Expand Up @@ -81,14 +82,23 @@
"composer/ca-bundle": [
"patches/cloudflare-ca.patch"
],
"hoa/exception": [
"patches/Idle.patch"
],
"hoa/file": [
"patches/File.patch",
"patches/Read.patch"
],
"hoa/iterator": [
"patches/Buffer.patch",
"patches/Lookahead.patch"
],
"hoa/compiler": [
"patches/HoaException.patch",
"patches/Invocation.patch",
"patches/Rule.patch",
"patches/Lexer.patch"
"patches/Lexer.patch",
"patches/TreeNode.patch"
],
"hoa/consistency": [
"patches/Consistency.patch"
Expand All @@ -109,6 +119,10 @@
],
"nette/di": [
"patches/DependencyChecker.patch"
],
"nette/neon": [
"patches/NetteNeonStringNode.patch",
"patches/NeonParser.patch"
]
}
},
Expand Down
Loading
Loading