Fix chaining with static/self and $this
#3363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Aug 27, 2024
| assertType('StaticWithThisChained\Foo', self::newStaticStatic()); | ||
| assertType('StaticWithThisChained\Foo', Foo::newStaticStatic()); | ||
|
|
||
| assertType('static(StaticWithThisChained\Foo)', $this->newStatic()->getThis()); |
There was a problem hiding this comment.
Help needed - how can I mutate the scope to be static when static return type is analysed?
There was a problem hiding this comment.
@ondrejmirtes please see https://phpstan.org/r/29fcfdb5-f19e-4df2-9177-61ad88490c64 repro - do you know where the issue comes from and how it can be fixed? (static must never be converted to $this )
There was a problem hiding this comment.
@staabm might I ask you for a help? I have looked into the fix several times, but I am not familiar with mutating the scope logic and I do not know how to fix this myself.
mvorisek
force-pushed
the
fix_5946_this_into_static
branch
2 times, most recently
from
8440516 to
fd3a89a
Compare
mvorisek
force-pushed
the
fix_5946_this_into_static
branch
from
fd3a89a to
8eae77c
Compare
mvorisek
force-pushed
the
fix_5946_this_into_static
branch
from
8eae77c to
8ceb598
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix phpstan/phpstan#5946