Narrow array on count(), string on strlen() with positive-int #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Aug 30, 2024
src/Analyser/TypeSpecifier.php
Outdated
There was a problem hiding this comment.
moved this 2 if-blocks out of specifyTypesForConstantBinaryExpression as we no longer check for a constant type operand, but do a more general isInteger based handling, which includes unbound IntegerRangeType.
staabm
commented
Aug 30, 2024
src/Analyser/TypeSpecifier.php
Outdated
There was a problem hiding this comment.
compensated the now passed in maybe unbound IntegerRangeTypes
staabm
commented
Aug 30, 2024
There was a problem hiding this comment.
I think I did a mistake here in previous PR, as the array can still be empty in the else branch
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#11558