Skip to content

TypeSpecifier: Narrow (string) $expr like $expr != '' #3387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024
Merged

TypeSpecifier: Narrow (string) $expr like $expr != '' #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Analyser/TypeSpecifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,13 @@ public function specifyTypesInCondition(
$context,
$rootExpr,
);
} elseif ($expr instanceof Expr\Cast\String_) {
return $this->specifyTypesInCondition(
$scope,
new Node\Expr\BinaryOp\NotEqual($expr->expr, new ConstFetch(new Name\FullyQualified('false'))),
$context,
$rootExpr,
);
} elseif ($expr instanceof Expr\Cast\Bool_) {
return $this->resolveEqual(new Expr\BinaryOp\Equal($expr->expr, new ConstFetch(new Name\FullyQualified('true'))), $scope, $context, $rootExpr);
} elseif ($expr instanceof Node\Expr\BinaryOp\Equal) {
Expand Down
21 changes: 21 additions & 0 deletions tests/PHPStan/Analyser/nsrt/narrow-bool-cast.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,3 +27,24 @@ function doFoo(string $x, array $arr): void {
}
assertType('array{}|array{string}', $matches);
}

/** @param int<-5, 5> $x */
function castString($x, string $s, bool $b) {
if ((string) $x) {
assertType('int<-5, -1>|int<1, 5>', $x);
} else {
assertType('0', $x);
}

if ((string) $b) {
assertType('true', $b);
} else {
assertType('false', $b);
}

if ((string) strrchr($s, 'xy')) {
assertType('string', $s); // could be non-empty-string
} else {
assertType('string', $s);
}
}
Loading