Improve type narrowing after string functions #3390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 2, 2024
| $argType = $scope->getType($unwrappedLeftExpr->getArgs()[0]->value); | ||
|
|
||
| if ($argType->isString()->yes()) { | ||
| if ($rightType->isNonFalsyString()->yes()) { |
There was a problem hiding this comment.
instead of if ($constantStringValue !== '0') { we now rely on the type-system
|
This pull request has been marked as ready for review. |
staabm
force-pushed
the
nones
branch
2 times, most recently
from
46481ac to
8cb61a6
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR we only narrowed in comparisons with constant strings.
After this PR it works for any type of string