Fix late static binding calls for first class callable #3435
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
|
This pull request has been marked as ready for review. |
ondrejmirtes
requested changes
Sep 12, 2024
|
|
||
| assertType('StaticLateBinding\A', A::retStatic(...)()); | ||
| assertType('StaticLateBinding\B', B::retStatic(...)()); | ||
| assertType('Closure', self::retStatic()(...)); // should be static(StaticLateBinding\B) |
There was a problem hiding this comment.
This shows this doesn't really work well.
There was a problem hiding this comment.
fixed, typo on my side in the test
There was a problem hiding this comment.
@ondrejmirtes can this PR be merged?
|
This pull request has been marked as ready for review. |
|
This pull request has been marked as ready for review. |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
followup to #3361
dedup + fix first class callable