Expose Output::isDecorated and Output::isVeryVerbose #3436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
|
@ondrejmirtes This might be a breaking change for 1.12. Maybe we can add the method to the SymfonyOutput in 1.12 . And add it to the Output interface in 2.x? Then in my code, I can do a check if |
This can be used by an ErrorFormatter to determine if `--ansi` or `--no-ansi` was used. A use case can be to toggle rendering of colors or hyperlinks. When ansi is not enabled, one might want to render a link differently.
I don't think so. No one has a reason to implement a custom Output. Please add the interface to BcUncoveredInterface (a list of interfaces that users can use but not implement). |
ondrejmirtes
requested changes
Sep 13, 2024
|
Updated the PR |
ruudk
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used by an ErrorFormatter to determine if
--ansior--no-ansiwas used.A use case can be to toggle rendering of colors or hyperlinks.
When ansi is not enabled, one might want to render a link differently.
Needed for https://github.com/TicketSwap/phpstan-error-formatter