Fix unassigning the last offset in a ConstantArray that is a list #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nope, I was overlooking https://3v4l.org/n5E7F so the array is a list until another element is added again. ouch. might need changes to UPDATE: adapted |
|
This pull request has been marked as ready for review. |
|
Closing because of: phpstan/phpstan#11718 (comment) |
|
ok. the changes here made the "array with last item unset"-is-still-a-list part work while also removing the list when more is assigned. it indeed feels slightly weird and a non-well-defined state though |
|
We can't do that because if you passed it somewhere else as a list, and the other place appended an element, the assumption would be broken, and PHPStan would think it has a list but in reality it wouldn't be a list. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those keep being lists.
Fixes phpstan/phpstan#11718