Refactor RegexGroupParser for more immutability and less pass-by-ref #3479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Sep 25, 2024
Comment on lines
-385
to
-389
| TrinaryLogic &$isNonEmpty, | ||
| TrinaryLogic &$isNonFalsy, | ||
| TrinaryLogic &$isNumeric, | ||
| bool &$inOptionalQuantification, | ||
| ?array &$onlyLiterals, |
There was a problem hiding this comment.
essentially I moved these by-ref parameters into a separate class without anymore by-ref semantics
|
This pull request has been marked as ready for review. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
less magic, less error prone