Report unparseable regexp when compilable #3505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
error_on_unparseable_const_regex
branch
from
19759d3 to
69c44db
Compare
|
I'm scared to see what shows up, but that'd definitely be valuable. |
|
This pull request has been marked as ready for review. |
|
Errors reported by PHPStan should be bugs in analysed code fixable by the developer. Errors reported by PHPStan should not be PHPStan bugs and give more work to PHPStan users. Feel free to use this rule in your own projects, and fix those bugs in PHPStan based on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs #3488 to be merged first
Figuring out regexes that are not parsed by PHPStan grammar is hard. Let's help developers and they can help us.
With good reports PHPStan grammar can be improved quickly so all PCRE patterns are supported by PHPStan parser.