Introduce Scope::getMaybeDefinedVariables #3521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've opened the pull request against the latest branch 2.0.x. PHPStan 2.0 is not going to be released for months. If your code is relevant on 1.12.x and you want it to be released sooner, please rebase your pull request and change its target to 1.12.x. |
ruudk
force-pushed
the
getMaybeDefinedVariables
branch
from
46fdb83 to
c2195b8
Compare
|
Every time 🙈 |
|
I think a test could fit in https://github.com/phpstan/phpstan-src/blob/1.12.x/tests/PHPStan/Analyser/ScopeTest.php |
By doing this, when you are inside MutatingScope you can press "Go to test" in PHPStorm and it navigates you right to this test.
|
@staabm Thanks. Somehow I could not find it when using The tests are added. @ondrejmirtes This is ready for review! |
|
Thank you! |
janedbal
reviewed
Oct 2, 2024
|
|
||
| /** | ||
| * @api | ||
| * @return array<int, string> |
There was a problem hiding this comment.
Copied from getDefinedVars
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11772
Where would be the best way to create a test for this?