Skip to content

Conversation

ManuelHu
Copy link
Contributor

@ManuelHu ManuelHu commented Oct 7, 2024

constructed attributes returned by ReflectionX->getAttributes() are always added with the next array indices:

So the return type should be list<...> instead of array<mixed,,...>.

@ManuelHu ManuelHu changed the base branch from 2.0.x to 1.12.x October 7, 2024 18:44
@ManuelHu ManuelHu force-pushed the fix_reflectionattribute_list branch from e60bd77 to 2380dac Compare October 7, 2024 18:46
@ManuelHu ManuelHu force-pushed the fix_reflectionattribute_list branch from 2380dac to eda71c4 Compare October 7, 2024 18:58
@ondrejmirtes ondrejmirtes merged commit ee802d6 into phpstan:1.12.x Oct 7, 2024
474 of 500 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@ManuelHu ManuelHu deleted the fix_reflectionattribute_list branch October 7, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants