Support CallLike with variable method name #3553
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
just now saw the feedback in phpstan/phpstan#2920 (comment) - will consider |
staabm
commented
Oct 8, 2024
Comment on lines
+37
to
+39
| if ($node->name instanceof Node\Identifier) { | ||
| $methodNames = [$node->name->name]; | ||
| } else { |
There was a problem hiding this comment.
I see there are a lot of rules which early exit on :
if (!$node->name instanceof Node\Identifier) {
return [];
}
maybe these are easy to enhance with a similar check I did here.
(just supporting the getConstantStrings() case)
|
the issue targeted with this PR was resolved in the meantime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#2920