Fix signature type for default-null parameters #3586
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been marked as ready for review. |
|
These kind of changes can be reviewed here: https://github.com/phpstan/phpstan-src/actions/runs/11643344314/job/32424024307 Please go through the diff and decide if there's a problem with this PR or not :) |
|
@staabm Hi, I wanted to work on phpstan/phpstan#12282 and just discovered your PR Do you agree that phpstan/phpstan#7522 and phpstan/phpstan#12282 are duplicates ? If your PR solves both, it could be great to rebase/target 2.1.x. (or do you want me to do it ?) Thanks! |
|
Hey 👋 Feel free to pick the commit and push a new PR |
Sure, done with #3912 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#7522