More details php version information in diagnose

[staabm]

as requested in #3584 (comment)

[ondrejmirtes]

This shows me we need to do a bit of a refactoring.

Current state: ComposerPhpVersionFactory either reads phpVersion from phpstan.neon (if it has min+max), or from composer.json. And ConstantResolver uses ComposerPhpVersionFactory for this logic.

Wanted state: ComposerPhpVersionFactory only reads PHP version from composer.json, as its name says. And then ConstantResolver decides if it should read phpVersion from phpstan.neon with min/max provided. And if it's not there then it should read it from ComposerPhpVersionFactory.

Feel free to do this in a separate PR before this one. Thanks.

[ondrejmirtes]

I'd say the composer.json PHP version is irrelevant if there's phpVersion.min+max version in phpstan.neon. The diagnose command should reflect that and print composer.json version only if phpVersion in phpstan.neon is int or null.

[ondrejmirtes]

Looking at ComposerPhpVersionFactory usages, I found a bug: VersionCompareFunctionDynamicReturnTypeExtension only looks at composer version, not phpVersion.min+max version.

[staabm]

Looking at ComposerPhpVersionFactory usages, I found a bug: VersionCompareFunctionDynamicReturnTypeExtension only looks at composer version, not phpVersion.min+max version.

I will send a separate PR

[ondrejmirtes]

Awesome, now it makes sense to me :)

[CypherReymax96]

Fix_Resolve_Complete