Remove from final exit points every exception that is catched #3629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ondrejmirtes Should I open a PR for the 1.12.x branch as well? Or are you gonna back-porting all issues from the 2.0.x back to the 1.12.x? |
Bellangelo
force-pushed
the
remove-exitpoints-if-they-are-catched
branch
from
e405835 to
f51cc11
Compare
|
If you want this PR to apply to 1.x you should target the PR like that. It usually only makes sense if the PR does not conflict too much with 2.x |
|
I'm not sure if all of those expected errors should disappear. That's why I didn't merge this yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#11906