Skip to content

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Nov 26, 2024

I see this test fail more often on PRs lately with output like:

php vendor/bin/paratest --runner WrapperRunner --no-coverage --group exec
ParaTest v6.6.3 upon PHPUnit 9.6.20 by Sebastian Bergmann and contributors.

............................E...                                 32 / 32 (100%)

Time: 00:35.534, Memory: 80.00 MB

There was 1 error:

1) PHPStan\Command\ErrorFormatter\BaselineNeonErrorFormatterIntegrationTest::testRunUnixFileWithWindowsBaseline
PHPStan\ShouldNotHappenException: Could not clear result cache.

D:\a\phpstan-src\phpstan-src\tests\PHPStan\Command\ErrorFormatter\BaselineNeonErrorFormatterIntegrationTest.php:74
D:\a\phpstan-src\phpstan-src\tests\PHPStan\Command\ErrorFormatter\BaselineNeonErrorFormatterIntegrationTest.php:54

FAILURES!
Tests: 32, Assertions: 82, Errors: 1.
make: *** [Makefile:9: tests-integration] Error 2

lets see whether we can get a more meaningful output which might help to fix the underlying problem

@staabm staabm marked this pull request as ready for review November 26, 2024 19:14
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@staabm staabm force-pushed the ease-debug branch 2 times, most recently from 68ea959 to de5432f Compare December 1, 2024 16:17
@ondrejmirtes
Copy link
Member

I don't think we need the debugging. It's obvious what's going on. paratest runs in multiple threads. All these test methods share the same result cache file. Windows doesn't like multiple processes accessing the same file and sometimes fails.

The solution is to have different tmpDir for each of these tests.

@staabm staabm deleted the ease-debug branch January 19, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants