Nuke OriginalPropertyTypeExpr

[herndlm]

just want to know what this affects outside of PHPStan's test suite..

I assume it will lead to some improvements in edge cases while causing some other edge case issues, especially with invalid offset setting on array props.

[ondrejmirtes]

There aren't many integration tests running right now :)

[herndlm]

ok, still interesting. looks like this would fix

• Updating nullable member of array field $this->array['field'] = expr does not use context information phpstan#7880
• Threaded[] = something generates bogus error phpstan#6571
• Bogus error when assigning to offset of ArrayObject<array<something>> phpstan#6398

downside could be some weird types in errors in some cases, especially phpstan's test suite that tries to assign incorrect types in a row. more integration tests would be interesting I guess :)

[herndlm]

Ok, I think I know what I have to do :)

[ondrejmirtes]

Finally figured it out a8cae55

[herndlm]

Finally figured it out a8cae55

amazing that you still remembered this PR :D

[ondrejmirtes]

There are things that haunt me for years until they're solved 😀