Add PHP Configurator #3688
Closed
Add PHP Configurator #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't a project that you can just implement without prior discussion, and expect it to be merged. Although one day I'd like to switch away from .neon, I'm not ready to tackle this project right now. Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it. |
|
I was hoping the PR would be the place for the discussion/proof-of-concept. |
|
Would you be open to discussing this via an issue on https://github.com/phpstan/phpstan/issues? |
|
Yeah, sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe there is no better way to configure a PHP application than with PHP code.
The advantages that I see are: