Lazier return in UnionType->isSuperTypeOf() (~40% faster)
#3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After #3692 is merged, you need to do |
staabm
force-pushed
the
lazy-or
branch
4 times, most recently
from
9bebc23 to
7d1503d
Compare
|
This pull request has been marked as ready for review. |
|
here we go |
|
Thank you. |
|
No, you didn't do what I meant :( I have to go back. |
|
You should have merged 1.12.x which already contained your PR but you didn't do that. |
|
This is what you did:
The problem is that the merge conflict was not resolved. Your commit from 1.12.x was not in 2.0.x. When I did This is what I meant:
Please bear that in mind next time :) Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.0.x variant of #3692