Fix ConstantArrayType::isCallable #3717
Conversation
| return TrinaryLogic::createYes()->and(...$results); | ||
| $isCallable = TrinaryLogic::createYes()->and(...$results); | ||
| if ($isCallable->yes()) { | ||
| $callableArray = $this->getClassOrObjectAndMethods(); |
There was a problem hiding this comment.
This is ineffective. This method was already called once inside findTypeAndMethodNames above. It's a bit of a mess right now.
I just made sure this kind of mistake isn't possible: 30b9cd8
So the fix should probably be done inside findTypeAndMethodNames but I'm not sure.
There was a problem hiding this comment.
So the fix should probably be done inside findTypeAndMethodNames but I'm not sure.
Not sure too. Depends of the purpose of the method.
Currently the findTypeAndMethodNames returns all the possible callable with at least a Maybe certainty. Cf #3637 (comment)
Currently it's not possible to create
ConstantArrayTypeAndMethod::createConcrete($type, $method->getValue(), TrinaryLogic::createNo());
So if you have a string 'foo'|'bar' and only 'foo' is a callable name, if it will returns 'foo'.
But it doesn't mean that 'foo'|'bar' is always a callable.
That's why I added the logic in isCallable to check the count of possible callable didn't drop (which mean some value has No as certainty).
VincentLanglet
force-pushed
the
isCallable
branch
from
58de58f to
c427740
Compare
VincentLanglet
force-pushed
the
isCallable
branch
from
c427740 to
c8b3dda
Compare
2 participants
Reopened from #3637 since I messed up with my branches (and the previous changes was on 1.12.x branch...)
Closes phpstan/phpstan#12063