Skip to content

Do not report constructor unused parameter if class is an Attribute class #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 16, 2025
Merged

Do not report constructor unused parameter if class is an Attribute class #3776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Rules/Classes/UnusedConstructorParametersRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,9 @@ public function processNode(Node $node, Scope $scope): array
if (count($originalNode->params) === 0) {
return [];
}
if ($node->getClassReflection()->isAttributeClass()) {
return [];
}

$message = sprintf(
'Constructor of class %s has an unused parameter $%%s.',
Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Classes/UnusedConstructorParametersRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ public function testBug1917(): void
$this->analyse([__DIR__ . '/data/bug-1917.php'], []);
}

public function testBug7165(): void
{
$this->analyse([__DIR__ . '/data/bug-7165.php'], []);
}

public function testBug10865(): void
{
$this->analyse([__DIR__ . '/data/bug-10865.php'], []);
Expand Down
12 changes: 12 additions & 0 deletions tests/PHPStan/Rules/Classes/data/bug-7165.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<?php declare(strict_types=1); // lint >= 8.0

namespace Bug7165;

#[\Attribute]
class MyAttribute
{
public function __construct(string $name)
{
}
}

Loading