More precise return type for mysqli_fetch_all() #3778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxan
force-pushed
the
patch-1
branch
3 times, most recently
from
3ab861f to
945e142
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqli_fetch_all()andmysqli_result::fetch_all()returns a sequentially indexed array (list) of arrays, so convert its return type fromarraytolist<array>.The fullly specified return type for these functions is a bit more complicated, as it depends on the
$modeparameter:MYSQLI_ASSOC, it's a list of associative arrays, i.e.list<array<string, string|int|float|null>>.MYSQLI_NUM, it's a list of lists, i.e.list<list<array|int|float|null>>.MYSQLI_BOTH, it's a list of enumerated and associative arrays, i.e.list<array<string|int, string|int|float|null>>.We could specify the return type as
list<array<string|int, string|int|float|null>>to catch all these cases, but I'm not sure that'd be very helpful, as it might force users to deal with types in the union that will never happen in their case. Themysqli_fetch_array()andmysqli_result::fetch_array()functions that share the same polymorphic behaviour are also typehinted as justarray.I think the CI failure is unrelated.