Prevent declaring hooked properties as readonly

[jakubtobiasz]

Fulfills Hooked properties cannot be readonly from phpstan/phpstan#12336 :)

[ondrejmirtes]

Also please do the same in the interface property rule, thank you.

[jakubtobiasz]

Hello @ondrejmirtes 👋🏼,

I've covered what you asked for :).

As I'm working on hooked properties and I see your list of to be done in that matter, what do you think about splitting PropertyInClassRule into PropertyInClassRule (non-hooked properties thingies only), HookedPropertyInAbstractClassRule, HookedPropertyInReadonlyClassRule, HookedPropertyInClassRule or something similar? I'm afraid keeping all these rules in a single class might affect readability and maintainability in the future :/.

[ondrejmirtes]

I think the current way is better. It's easier to see what is and what isn't covered. Some rules apply to all properties so with your suggestion there would have to be some duplication too.

[jakubtobiasz]

Ok, so do you anything more from me in this PR or I can take a next one :D.

[ondrejmirtes]

I moved a piece of code for better readability (fdda36e) which means the error is reported regardless of $node->isReadOnly() and no tests have failed. Can you please confirm this still works as intended?

[jakubtobiasz]

Seems legit 🤔

[ondrejmirtes]

Thank you!