-
Notifications
You must be signed in to change notification settings - Fork 543
Prevent declaring hooked properties as readonly #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent declaring hooked properties as readonly #3803
Conversation
912148c to
013940a
Compare
|
Also please do the same in the interface property rule, thank you. |
1d50e87 to
72ea3ac
Compare
|
Hello @ondrejmirtes 👋🏼, I've covered what you asked for :). As I'm working on hooked properties and I see your list of |
72ea3ac to
628013e
Compare
|
I think the current way is better. It's easier to see what is and what isn't covered. Some rules apply to all properties so with your suggestion there would have to be some duplication too. |
|
Ok, so do you anything more from me in this PR or I can take a next one :D. |
628013e to
fdda36e
Compare
|
I moved a piece of code for better readability (fdda36e) which means the error is reported regardless of |
|
Seems legit 🤔 |
|
Thank you! |
Fulfills
Hooked properties cannot be readonlyfrom phpstan/phpstan#12336 :)