Skip to content

Set editorUrl from xdebug configuration #3826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Set editorUrl from xdebug configuration #3826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/DependencyInjection/ContainerFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,17 @@
use function count;
use function dirname;
use function extension_loaded;
use function get_cfg_var;
use function getenv;
use function ini_get;
use function is_array;
use function is_file;
use function is_readable;
use function is_string;
use function spl_object_id;
use function sprintf;
use function str_ends_with;
use function strtr;
use function substr;

/**
Expand Down Expand Up @@ -149,6 +152,12 @@ public function create(

$configurator->setAllConfigFiles($allConfigFiles);

if (!array_key_exists('editorUrl', $projectConfig['parameters'])) {
$configurator->addParameters([
'editorUrl' => $this->getEditorUrlFromPhpIni(),
]);
}

$container = $configurator->createContainer()->getByType(Container::class);
$this->validateParameters($container->getParameters(), $projectConfig['parametersSchema']);
self::postInitializeContainer($container);
Expand Down Expand Up @@ -391,4 +400,23 @@ private function processArgument($argument, bool $required = true)
return $argument;
}

/**
* Try to fetch an editor URL from php.ini by reading xdebug configuration.
*
* This works even if the xdebug extension is not loaded.
*/
private function getEditorUrlFromPhpIni(): ?string
{
$xdebugFileLinkFormat = ini_get('xdebug.file_link_format') ?: get_cfg_var('xdebug.file_link_format');

if (is_string($xdebugFileLinkFormat) && $xdebugFileLinkFormat !== '') {
return strtr($xdebugFileLinkFormat, [
'%f' => '%file%',
'%l' => '%line%',
]);
}

return null;
}

}
Loading