Skip to content

Fix GetNonVirtualPropertyHookReadRule on abstract property #3845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Fix GetNonVirtualPropertyHookReadRule on abstract property #3845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
861a6c0
Fix GetNonVirtualPropertyHookReadRule on abstract property
staabm Mar 2, 2025
0239c90
Update GetNonVirtualPropertyHookReadRule.php
staabm Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Rules/Properties/GetNonVirtualPropertyHookReadRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,10 @@ public function processNode(Node $node, Scope $scope): array
continue;
}

if ($propertyReflection->isAbstract()->yes()) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this is a wrong fix. Instead, the foreach over the hooks above should check if the get hook has a body or not.

continue;
}

$errors[] = RuleErrorBuilder::message(sprintf(
'Get hook for non-virtual property %s::$%s does not read its value.',
$classReflection->getDisplayName(),
Expand Down
9 changes: 9 additions & 0 deletions tests/PHPStan/Rules/Properties/GetNonVirtualPropertyHookReadRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,13 @@ public function testRule(): void
]);
}

public function testAbstractProperty(): void
{
if (PHP_VERSION_ID < 80400) {
$this->markTestSkipped('Test requires PHP 8.4.');
}

$this->analyse([__DIR__ . '/data/get-abstract-property-hook-read.php'], []);
}

}
15 changes: 15 additions & 0 deletions tests/PHPStan/Rules/Properties/data/get-abstract-property-hook-read.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php // lint >= 8.4

namespace GetAbstractPropertyHook;

class NonFinalClass
{
public string $publicProperty;
}

abstract class Foo extends NonFinalClass
{
abstract public string $publicProperty {
get;
}
}
Loading