Skip to content

Conversation

phpstan-bot
Copy link
Collaborator

Update PhpStorm stubs

@ondrejmirtes
Copy link
Member

Hey @VincentLanglet, I'd appreciate your help here. Can you please pinpoint what change in jetbrains/phpstorm-stubs is causing this test to fail? https://github.com/phpstan/phpstan-src/actions/runs/13643039363/job/38136751044?pr=3851

I'd like to understand what we need to fix here and who's right :)

@VincentLanglet
Copy link
Contributor

VincentLanglet commented Mar 4, 2025

Hi @ondrejmirtes

I assume it's https://github.com/JetBrains/phpstorm-stubs/pull/1715/files
They added @throws Exception with #[PhpStormStubsElementAvailable(from:'5.5', to: '8.2')]

And the truth is on their side DateMalformedStringException and similar exception are introduced in 8.3+ only.

Is it helping ?

@ondrejmirtes ondrejmirtes force-pushed the create-pull-request/patch-8kv6pms branch from 2235e7e to cb8998e Compare March 6, 2025 12:04
@ondrejmirtes ondrejmirtes merged commit 274e766 into 2.1.x Mar 6, 2025
415 of 417 checks passed
@ondrejmirtes ondrejmirtes deleted the create-pull-request/patch-8kv6pms branch March 6, 2025 12:40
@ondrejmirtes
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants