Fix condition of fall-through case not used for exhaustive checks #3900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
commented
Mar 23, 2025
| 116, | ||
| ], | ||
| [ | ||
| // could be Variable $variableInSecondCase in isset() always exists and is not nullable. | ||
| 'Variable $variableInSecondCase in isset() is never defined.', |
There was a problem hiding this comment.
So this error already was incorrect. The other one is now also broken, because its condition is also used
|
From the issue bot it looks like it fixed more issues: https://github.com/phpstan/phpstan-src/actions/runs/14018968530 Please add regression tests for them. |
|
Thanks, I added tests for the listed issues. |
|
Awesome, thank you! |
This was referenced Mar 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix phpstan/phpstan#11064. Unfortunately this causes a regression elsewhere, which by the looks of it already didn't work completely.
The problem there is that the assignment is forgotten because of the
$scopeForBranches = $scopeForBranches->filterByFalseyValue($fullCondExpr).