Skip to content

Fix PDOStatement getIterator stub type #3974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 30, 2025
Merged

Fix PDOStatement getIterator stub type #3974

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b031f5c
fixes #8886
mbolli Apr 30, 2025
0679c46
remove test file from NodeScopeResolverTest
mbolli Apr 30, 2025
ac4cf73
PHP7.4 doesn't have `PDOStatement::getIterator()`
mbolli Apr 30, 2025
13c0405
early return
mbolli Apr 30, 2025
c0efe59
Use `// lint`
mbolli Apr 30, 2025
3d1d601
replace test import/yield with a comment
mbolli Jul 29, 2025
9ee7457
Update tests/PHPStan/Analyser/NodeScopeResolverTest.php
ondrejmirtes Aug 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stubs/PDOStatement.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,9 @@ class PDOStatement implements Traversable, IteratorAggregate
* @return array{name: string, table?: string, native_type?: string, len: int, flags: array<int, string>, precision: int<0, max>, pdo_type: PDO::PARAM_* }|false
*/
public function getColumnMeta(int $column) {}

/**
* @return Iterator
*/
public function getIterator() {}
}
2 changes: 2 additions & 0 deletions tests/PHPStan/Analyser/NodeScopeResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ private static function findTestFiles(): iterable
yield __DIR__ . '/../Rules/Methods/data/bug-4801.php';
yield __DIR__ . '/../Rules/Arrays/data/narrow-superglobal.php';
yield __DIR__ . '/../Rules/Methods/data/bug-12927.php';

// note: files in ./nsrt will be automatically picked up
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to add this.

This is a consequence of the first line

foreach (self::findTestDataFilesFromDirectory(__DIR__ . '/nsrt') as $testFile) {
			yield $testFile;
		}

}

/**
Expand Down
13 changes: 13 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-8886.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php // lint >= 8.0

namespace Bug8886;

use PDO;
use function PHPStan\Testing\assertType;

function testPDOStatementGetIterator(): void {
$pdo = new PDO('sqlite::memory:');
$stmt = $pdo->query('SELECT 1');

assertType('Iterator', $stmt->getIterator());
}
Loading